[PATCH] D57517: [llvm-objcopy] Allow using regex in name comparison

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: tools/llvm-objcopy/CopyConfig.h:53
+template <class NameTy> class NameOrRegex {
+  NameTy Name;
+  // Regex is shared between mumltiple CopyConfig instances.
----------------
tbh I have mixed feelings regarding this,
1. so basically string comparison is just a particular case of regex - maybe we can simply use Regex and don't need this class ?
2. khm, where is CopyConfig copied ? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57517/new/

https://reviews.llvm.org/D57517