[PATCH] D57650: GlobalISel: Enforce operand types for constants

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 3 06:33:19 PST 2019


arsenm created this revision.
arsenm added reviewers: aditya_nandakumar, aemerson, paquette, volkan, dsanders.
Herald added subscribers: Petar.Avramovic, javed.absar, kristof.beyls, rovka, nhaehnle, wdng, jvesely.

A number of of tests were using imm operands, not cimm. Since CSE
relies on the exact ConstantInt* pointer used, and implicit
conversions are generally evil, also enforce the bitsize of the types.


https://reviews.llvm.org/D57650

Files:
  lib/CodeGen/MachineVerifier.cpp
  test/CodeGen/AArch64/GlobalISel/localizer.mir
  test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-extending-loads.mir
  test/CodeGen/AArch64/GlobalISel/regbankselect-default.mir
  test/CodeGen/AArch64/GlobalISel/select-binop.mir
  test/CodeGen/AMDGPU/GlobalISel/inst-select-implicit-def.mir
  test/CodeGen/AMDGPU/GlobalISel/legalize-and.mir
  test/CodeGen/AMDGPU/GlobalISel/legalize-extract-vector-elt.mir
  test/CodeGen/AMDGPU/GlobalISel/legalize-icmp.mir
  test/CodeGen/AMDGPU/GlobalISel/legalize-or.mir
  test/CodeGen/AMDGPU/GlobalISel/legalize-select.mir
  test/CodeGen/AMDGPU/GlobalISel/legalize-xor.mir
  test/CodeGen/AMDGPU/GlobalISel/regbankselect-and.mir
  test/CodeGen/AMDGPU/GlobalISel/regbankselect-default.mir
  test/CodeGen/AMDGPU/GlobalISel/regbankselect-sadde.mir
  test/CodeGen/AMDGPU/GlobalISel/regbankselect-ssube.mir
  test/CodeGen/AMDGPU/GlobalISel/regbankselect-uadde.mir
  test/CodeGen/AMDGPU/GlobalISel/regbankselect-usube.mir
  test/CodeGen/ARM/GlobalISel/arm-instruction-select.mir
  test/CodeGen/ARM/GlobalISel/arm-legalize-consts.mir
  test/CodeGen/ARM/GlobalISel/arm-regbankselect.mir
  test/CodeGen/ARM/GlobalISel/select-revsh.mir
  test/CodeGen/X86/GlobalISel/select-ashr-scalar.mir
  test/CodeGen/X86/GlobalISel/select-lshr-scalar.mir
  test/CodeGen/X86/GlobalISel/select-shl-scalar.mir
  test/Verifier/test_g_constant.mir
  test/Verifier/test_g_fconstant.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57650.184948.patch
Type: text/x-patch
Size: 37735 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190203/d0f6488d/attachment.bin>


More information about the llvm-commits mailing list