[PATCH] D57627: [BasicAA] Cache nonEscapingLocalObjects for alias() calls.

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added inline comments.


================
Comment at: lib/Analysis/BasicAliasAnalysis.cpp:122-126
+  if (IsCapturedCache) {
+    auto CacheIt = IsCapturedCache->find(V);
+    if (CacheIt != IsCapturedCache->end())
+      return CacheIt->second;
+  }
----------------
Can this function ever be re-entered? It seems unlikely given the structure.

If not, hoist the `CacheIt` iterator out, use insert, and then update it below rather than doing another lookup?


================
Comment at: lib/Analysis/BasicAliasAnalysis.cpp:154-155
+    }
 
   return false;
 }
----------------
Why not cache this too?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57627/new/

https://reviews.llvm.org/D57627