[PATCH] D57584: [DebugInfo][DAG] Reduce SelectionDAGs reordering of variables referring to Arguments

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5357
+    // need to let them dangle until they get an SDNode.
+    bool isParamOfFunc = isa<Argument>(V) && Variable->isParameter() &&
+                         Variable->getScope() == FuncInfo.Fn->getSubprogram();
----------------
bjope wrote:
> Capitalize local variable name.
Wouldn't this condition incorrectly also identify an inlined argument of a recursive function call as being an argument of the outermost non-inlined function? I think you may also need to check the inlinedAt of the dbg.value is null.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57584/new/

https://reviews.llvm.org/D57584