[PATCH] D57608: [NFC][GlobalISel]: Add a convenience method to MachineInstrBuilder to simplify getOperand(i).getReg()

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 1 16:10:35 PST 2019


aditya_nandakumar added a comment.

In D57608#1381719 <https://reviews.llvm.org/D57608#1381719>, @aemerson wrote:

> If we're going to add a helper to shave some characters off, we might as well go for something really short like getOpReg().


That works for me as well. While this seems really trivial, this is repeated lots of times and gets annoying very quickly - kind of like MI->getMF() vs MI->getParent()->getParent().


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57608/new/

https://reviews.llvm.org/D57608





More information about the llvm-commits mailing list