[PATCH] D57608: [NFC][GlobalISel]: Add a convenience method to MachineInstrBuilder to simplify getOperand(i).getReg()

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 1 13:29:27 PST 2019


aditya_nandakumar marked an inline comment as done.
aditya_nandakumar added inline comments.


================
Comment at: lib/Target/AArch64/AArch64LegalizerInfo.cpp:501
     unsigned ListTmp = MRI.createGenericVirtualRegister(PtrTy);
-    MIRBuilder.buildGEP(ListTmp, List, AlignMinus1->getOperand(0).getReg());
 
----------------
arsenm wrote:
> Why does buildGEP use register inputs instead of SrcOp/DstOp like most of the other build functions?
I believe this was written way before the improvements to MachineIRBuilder and hasn't been updated since.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57608/new/

https://reviews.llvm.org/D57608





More information about the llvm-commits mailing list