[PATCH] D57024: [AMDGPU] Switched HSA metadata to use MsgPackDocument

[Scott Linder via Phabricator via llvm-commits]

scott.linder added a comment.
Herald added a project: LLVM.

Thank you for updating this! I only have one small suggestion, but otherwise it LGTM.



================
Comment at: lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.h:55
+  std::unique_ptr<msgpack::Document> HSAMetadataDoc =
+      std::unique_ptr<msgpack::Document>(new msgpack::Document);
 
----------------
Small nit, but could this be `llvm::make_unique<msgpack::Document>()`?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57024/new/

https://reviews.llvm.org/D57024