[PATCH] D57603: [WebAssembly] Add codegen support for the import_field attribute

[Sam Clegg via Phabricator via llvm-commits]

sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: llvm-commits.

LGTM % comments



================
Comment at: include/llvm/MC/MCSymbolWasm.h:36
+      : MCSymbol(SymbolKindWasm, Name, isTemporary), ModuleName("env"),
+        FieldName(getName().str()) {}
   static bool classof(const MCSymbol *S) { return S->isWasm(); }
----------------
Should we make these both Optional to save some space?  Since in the vast majority of cases they will not be set?

It might be nice to be able to distinguish between MCSymbol with custom module names/fields and those without.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57603/new/

https://reviews.llvm.org/D57603