[PATCH] D57546: [WebAssembly] Make segment/size/type directives optional in asm

[Derek Schuff via Phabricator via llvm-commits]

dschuff added inline comments.


================
Comment at: lib/MC/MCParser/WasmAsmParser.cpp:97
+    // auto WS = getContext().getWasmSection(Name, SectionKind::getText());
+    // getStreamer().SwitchSection(WS);
     return false;
----------------
aardappel wrote:
> sbc100 wrote:
> > Why not just remove this?    Same below.
> I thought I'd leave this in at least for review, and potentially also to show "this is what this operation would do", since it is kinda odd that we parse the directive, then don't do anything with it.
> 
> I mean, I could remove all the parsing code and replace it with code that skips this directive, but I thought I'd leave it in, should we have a need for it later.
Is it really true that we never use the section directive? I guess for functions that makes sense but what about for data sections?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57546/new/

https://reviews.llvm.org/D57546