[PATCH] D57329: [gn] Checking in BUILD.gn files for clang-tidy and clang-apply-replacements

[Yves Gerey via Phabricator via llvm-commits]

yvesg accepted this revision.
yvesg added a comment.
This revision is now accepted and ready to land.
Herald added a project: LLVM.

Nice, LGTM!



================
Comment at: llvm/utils/gn/build/BUILD.gn:152
 
+config("clang_apply_replacements_code") {
+  include_dirs = [
----------------
I'm surprised there is a config for this, but not for clang-tidy itself. Why is that so?


================
Comment at: llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn:19
+
+    # TODO(mbonadei): FIXME.
+    # ClangSACheckers
----------------
What should be fixed? I.e. what is the current limitation?
Static Analyzer checks not available? If so, the following deps could be commented.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57329/new/

https://reviews.llvm.org/D57329