[PATCH] D57588: [AMDGPU] Fix for vector element insertion

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 1 07:19:15 PST 2019


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with a more descriptive comment



================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:4374
+
+  // Duplicate the value so that it doesn't matter which element is written
+  SDValue ExtVal = DAG.getNode(ISD::BITCAST, SL, IntVT,
----------------
Can you elaborate more in this comment?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57588/new/

https://reviews.llvm.org/D57588





More information about the llvm-commits mailing list