[PATCH] D57030: [CommandLine] Don't print empty sentinel values from EnumValN lists in help text

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 1 02:58:17 PST 2019


jhenderson added a comment.

I've been able to reproduce the failure by extending the length of the switch by a large amount. I think, though not yet confirmed, that the problem is that this patch didn't adjust the apparent option width due to adding "=<value>". You may be seeing it because you are building without the Hexagon target? That causes the `-aarch64-neon-syntax=<value>` line to be the longest arg string, and greater than the GlobalWidth, I believe, causing an underflow somewhere in the adjusted code.

I'll look at fixing that.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57030/new/

https://reviews.llvm.org/D57030





More information about the llvm-commits mailing list