[PATCH] D57560: [clangd] Link libclangAST into clangd tool

[Ilya Biryukov via llvm-commits]

Thanks for fixing this, I don't build with -DBUILD_SHARED_LIB=On, hence I
never noticed the problem in the first place.

On Fri, Feb 1, 2019 at 12:21 PM Roman Lebedev <lebedev.ri at gmail.com> wrote:

> I don't think there are *any* bots with -DBUILD_SHARED_LIBS=ON
> Would be *really* good to get one, such issues are, while not *too* common
> (one a month or so), but are kinda painful to sort through..
>
> On Fri, Feb 1, 2019 at 12:16 PM Sam McCall <sammccall at google.com> wrote:
> >
> > Thanks for sorting that out!
> > Do we not have bots that build with shared libs, or did we miss the mail?
> >
> > On Fri, Feb 1, 2019 at 9:59 AM Roman Lebedev via Phabricator <
> reviews at reviews.llvm.org> wrote:
> >>
> >> lebedev.ri added a comment.
> >>
> >> And it turns out that wasn't enough, so i have additionally committed
> rL352843 <https://reviews.llvm.org/rL352843>.
> >> All good after that (other than D57556 <https://reviews.llvm.org/D57556
> >).
> >>
> >>
> >> Repository:
> >>   rG LLVM Github Monorepo
> >>
> >> CHANGES SINCE LAST ACTION
> >>   https://reviews.llvm.org/D57560/new/
> >>
> >> https://reviews.llvm.org/D57560
> >>
> >>
> >>
>


-- 
Regards,
Ilya Biryukov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190201/edfbe1f9/attachment.html>