[PATCH] D57568: [SCEV] Optimize getting SCEV of one-input Phis

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 1 00:10:15 PST 2019


mkazantsev marked an inline comment as done.
mkazantsev added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:5350
   if (Value *V = SimplifyInstruction(PN, {getDataLayout(), &TLI, &DT, &AC}))
     if (LI.replacementPreservesLCSSAForm(PN, V))
       return getSCEV(V);
----------------
Basically, I guess that we could just have deleted this check for same effect. Is there a reason to keep it? What's bad about breaking LCSSA in SCEV?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57568/new/

https://reviews.llvm.org/D57568





More information about the llvm-commits mailing list