[PATCH] D57561: [ThinLTO] Detect partially split modules during the thin link

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson created this revision.
tejohnson added a reviewer: pcc.
Herald added subscribers: dexonsmith, steven_wu, eraman, inglorion, mehdi_amini.
Herald added a project: LLVM.

The changes to disable LTO unit splitting by default (r350949) and
detect inconsistently split LTO units (r350948) are causing some crashes
when the inconsistency is detected in multiple threads simultaneously.
Fix that by having the code always look for the inconsistently split
LTO units during the thin link, by checking for the presence of type
tests recorded in the summaries.

Modify test added in r350948 to remove single threading required to fix
a bot failure due to this issue (and some debugging options added in the
process of diagnosing it).


Repository:
  rL LLVM

https://reviews.llvm.org/D57561

Files:
  lib/Transforms/IPO/LowerTypeTests.cpp
  lib/Transforms/IPO/WholeProgramDevirt.cpp
  test/ThinLTO/X86/cfi-devirt.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57561.184666.patch
Type: text/x-patch
Size: 5814 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190201/9222a353/attachment.bin>