[PATCH] D57501: Fix the lowering issue of intrinsics llvm.localaddress on X86

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 31 18:07:52 PST 2019


rnk added inline comments.
Herald added a project: LLVM.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:22363
+      else
+        Reg = RegInfo->getPtrSizedFrameRegister(MF);
+    }
----------------
Why doesn't this already work? The comment exists just to point out that getPtrSizedFrameRegister will sometimes select SP based on exactly the condition you've listed here, unless I'm mistaken.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57501/new/

https://reviews.llvm.org/D57501





More information about the llvm-commits mailing list