[PATCH] D57500: [WebAssembly] clang-tidy (NFC)

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 31 17:48:06 PST 2019


sbc100 added inline comments.


================
Comment at: lib/MC/MCWasmObjectTargetWriter.cpp:17
 // Pin the vtable to this object file
 MCWasmObjectTargetWriter::~MCWasmObjectTargetWriter() = default;
----------------
aheejin wrote:
> Hmm, I've deleted all unnecessary `= default` destructors, but I guess they had purposes..? Do you know what this is for?
As assume its just the above reason "to pin the vtable to this object file".

See: 
https://llvm.org/docs/CodingStandards.html#provide-a-virtual-method-anchor-for-classes-in-headers


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57500/new/

https://reviews.llvm.org/D57500





More information about the llvm-commits mailing list