[PATCH] D56611: [clangd] A code action to swap branches of an if statement

Thu Jan 31 17:45:19 PST 2019

sammccall added a comment.

In D56611#1379785 <https://reviews.llvm.org/D56611#1379785>, @nridge wrote:

> This commit is causing clangd to fail to link, with errors like this:
>
>   tools/clang/tools/extra/clangd/refactor/tweaks/CMakeFiles/obj.clangDaemonTweaks.dir/SwapIfBranches.cpp.o:SwapIfBranches.cpp:function clang::RecursiveASTVisitor<clang::clangd::(anonymous namespace)::FindIfUnderCursor>::TraverseParmVarDecl(clang::ParmVarDecl*): error: undefined reference to 'clang::ParmVarDecl::hasDefaultArg() const'
>
>
> (and dozens more that are similar).

Hi Nathan,
What platform is this on? Not seeing it on the buildbots.
Anything unusual in build setup (standalone build, building with shared libraries, etc)?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56611/new/

https://reviews.llvm.org/D56611