[PATCH] D57462: [llvm-objcopy][NFC] More error propagation (executeObjcopyOnArchive)

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.
Herald added a project: LLVM.

Any new test coverage for these new error propagation paths?



================
Comment at: llvm/tools/llvm-objcopy/llvm-objcopy.cpp:157
+    // iteration, and hence does not allow early returns.
+    (void)(bool) Err;
     Expected<std::unique_ptr<Binary>> ChildOrErr = Child.getAsBinary();
----------------
jhenderson wrote:
> I think this should be `cantFail(Err)`, right?
Oh, good call!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57462/new/

https://reviews.llvm.org/D57462