[PATCH] D57546: [WebAssembly] Make segment/size/type directives optional in asm

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 31 15:00:28 PST 2019


sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.
Herald added a project: LLVM.


================
Comment at: lib/MC/MCParser/WasmAsmParser.cpp:97
+    // auto WS = getContext().getWasmSection(Name, SectionKind::getText());
+    // getStreamer().SwitchSection(WS);
     return false;
----------------
Why not just remove this?    Same below.


================
Comment at: lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:680
+        onEndOfFunction();
+      }
       return false;
----------------
Remove curlies?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57546/new/

https://reviews.llvm.org/D57546





More information about the llvm-commits mailing list