[PATCH] D57044: [AArch64] OOptimize floating point materialization

Thu Jan 31 14:07:02 PST 2019

evandro added inline comments.

================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:5442
+  // The immediate value will be created with either MOVZ or MOVN.
+  if (!IsLegal && (VT == MVT::f64 || VT == MVT::f32))
+    IsLegal = AArch64_AM::isAnyMOVWMovAlias(ImmInt.getZExtValue(),
----------------
efriedma wrote:
> evandro wrote:
> > Since `fmov h0, w0` is legal, shouldn't `MVT::f16` be added here too?
> Yes, it's possible, but I'm fine handling it in a followup.  We currently don't have an isel pattern to generate that fmov.
OK.  Please, add a TODO comment here about it before pushing the patch.

Thank you.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57044/new/

https://reviews.llvm.org/D57044