[PATCH] D57520: [DAG] Aggressively cleanup dangling node in CombineZExtLogicopShiftLoad.

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 31 11:35:26 PST 2019


This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL352784: [DAG] Aggressively cleanup dangling node in CombineZExtLogicopShiftLoad. (authored by niravd, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D57520?vs=184525&id=184557#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57520/new/

https://reviews.llvm.org/D57520

Files:
  llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp


Index: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
===================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
+++ llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -8465,6 +8465,10 @@
                                 Load->getValueType(0), ExtLoad);
     CombineTo(Load, Trunc, ExtLoad.getValue(1));
   }
+
+  // N0 is dead at this point.
+  recursivelyDeleteUnusedNodes(N0.getNode());
+
   return SDValue(N,0); // Return N so it doesn't get rechecked!
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57520.184557.patch
Type: text/x-patch
Size: 536 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190131/af7ad218/attachment.bin>


More information about the llvm-commits mailing list