[PATCH] D57264: Bump minimum toolchain version

Danila Malyutin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 31 06:51:29 PST 2019


danilaml added inline comments.


================
Comment at: cmake/modules/CheckCompilerVersion.cmake:73
+#include <ciso646>
+#if __GLIBCXX__ < ${GCC_MIN_DATE}
+#error Unsupported
----------------
hubert.reinterpretcast wrote:
> I can find `__GLIBCXX__` on GCC 6.x toolchains, but I haven't found it on older ones.
> ```
> #include <ciso646>
> extern char x[__GLIBCXX__]; // error: '__GLIBCXX__' was not declared in this scope
> ```
> 
It seems to be there but it looks like "#include <ciso646>" doesn't define it for older compilers for some reason.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57264/new/

https://reviews.llvm.org/D57264





More information about the llvm-commits mailing list