[PATCH] D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso marked an inline comment as done.
CarlosAlbertoEnciso added inline comments.


================
Comment at: test/CodeGen/X86/bbi-23595.ll:14
+
+; CHECK-NOT: LLVM ERROR: Broken function found, compilation aborted!
+; CHECK-LABEL: _Z7test_itv()
----------------
dstenb wrote:
> It seems to me that the negative check is unnecessary now. The positive checks verify that the `llvm.dbg.label` is dropped. Also, if the verifier errors out, opt exits with a non-zero exit code, so the test would fail due to that.
You are correct. The negative check is not required. I tried the test case without the fix and the it fails.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57444/new/

https://reviews.llvm.org/D57444