[PATCH] D57500: [WebAssembly] clang-tidy (NFC)

[Heejin Ahn via Phabricator via llvm-commits]

aheejin created this revision.
aheejin added reviewers: dschuff, sunfish, sbc100, jgravelle-google, tlively, aardappel, yurydelendik, kripken.
Herald added subscribers: llvm-commits, rupprecht, mgorny, MatzeB.

This patch fixes clang-tidy warnings on wasm-only files.
The list of checks used is:
`-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,readability-identifier-naming,modernize-*`
(LLVM's default .clang-tidy list is the same except it does not have
`modernize-*`. But I've seen in multiple CLs in LLVM the modernize style
was recommended and code was fixed based on the style, so I added it as
well.)

The common fixes are:

- Variable names start with an uppercase letter
- Function names start with a lowercase letter
- Use `auto` when you use casts so the type is evident
- Use inline initialization for class member variables
- Use `= default` for unnecessary default constructors / destructors
- Replaces explicit calls to the constructor in a return with a braced

initializer list


Repository:
  rL LLVM

https://reviews.llvm.org/D57500

Files:
  include/llvm/MC/MCSectionWasm.h
  include/llvm/MC/MCWasmStreamer.h
  lib/BinaryFormat/Wasm.cpp
  lib/MC/MCParser/WasmAsmParser.cpp
  lib/MC/MCSectionWasm.cpp
  lib/MC/MCWasmObjectTargetWriter.cpp
  lib/MC/MCWasmStreamer.cpp
  lib/MC/WasmObjectWriter.cpp
  lib/Object/WasmObjectFile.cpp
  lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
  lib/Target/WebAssembly/CMakeLists.txt
  lib/Target/WebAssembly/InstPrinter/WebAssemblyInstPrinter.cpp
  lib/Target/WebAssembly/MCTargetDesc/WebAssemblyAsmBackend.cpp
  lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCAsmInfo.cpp
  lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCAsmInfo.h
  lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCCodeEmitter.cpp
  lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.cpp
  lib/Target/WebAssembly/MCTargetDesc/WebAssemblyWasmObjectWriter.cpp
  lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp
  lib/Target/WebAssembly/WebAssemblyAsmPrinter.h
  lib/Target/WebAssembly/WebAssemblyCFGSort.cpp
  lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp
  lib/Target/WebAssembly/WebAssemblyCallIndirectFixup.cpp
  lib/Target/WebAssembly/WebAssemblyExplicitLocals.cpp
  lib/Target/WebAssembly/WebAssemblyFastISel.cpp
  lib/Target/WebAssembly/WebAssemblyFixFunctionBitcasts.cpp
  lib/Target/WebAssembly/WebAssemblyISelDAGToDAG.cpp
  lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
  lib/Target/WebAssembly/WebAssemblyISelLowering.h
  lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp
  lib/Target/WebAssembly/WebAssemblyLowerGlobalDtors.cpp
  lib/Target/WebAssembly/WebAssemblyMCInstLower.cpp
  lib/Target/WebAssembly/WebAssemblyMCInstLower.h
  lib/Target/WebAssembly/WebAssemblyMachineFunctionInfo.cpp
  lib/Target/WebAssembly/WebAssemblyMachineFunctionInfo.h
  lib/Target/WebAssembly/WebAssemblyMemIntrinsicResults.cpp
  lib/Target/WebAssembly/WebAssemblyOptimizeLiveIntervals.cpp
  lib/Target/WebAssembly/WebAssemblyOptimizeReturned.cpp
  lib/Target/WebAssembly/WebAssemblyPeephole.cpp
  lib/Target/WebAssembly/WebAssemblyPrepareForLiveIntervals.cpp
  lib/Target/WebAssembly/WebAssemblyRegColoring.cpp
  lib/Target/WebAssembly/WebAssemblyRegStackify.cpp
  lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.cpp
  lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.h
  lib/Target/WebAssembly/WebAssemblySelectionDAGInfo.cpp
  lib/Target/WebAssembly/WebAssemblySelectionDAGInfo.h
  lib/Target/WebAssembly/WebAssemblySetP2AlignOperands.cpp
  lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp
  lib/Target/WebAssembly/WebAssemblyTargetMachine.h
  lib/Target/WebAssembly/WebAssemblyTargetTransformInfo.cpp
  tools/llvm-objdump/WasmDump.cpp
  tools/llvm-readobj/WasmDumper.cpp
  tools/obj2yaml/wasm2yaml.cpp
  tools/yaml2obj/yaml2wasm.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57500.184457.patch
Type: text/x-patch
Size: 163504 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190131/84e41ec1/attachment-0001.bin>