[PATCH] D57421: [WebAssembly] Restore stack pointer right after catch instruction

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 30 13:40:47 PST 2019


dschuff accepted this revision.
dschuff added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Target/WebAssembly/WebAssemblyLateEHPrepare.cpp:353
+    // pad, after the catch instruction. (Catch instructions may have been
+    // reordered, and catch_all instructions have not been inserted yet, but
+    // those cases are handled in LateEHPrepare).
----------------
Is this comment still accurate? We don't need so many catch_all instructions now, right?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57421/new/

https://reviews.llvm.org/D57421





More information about the llvm-commits mailing list