[PATCH] D57451: [llvm-symbolizer][test] Extract tests from llvm-symbolizer.test and simplify (#3)

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 30 07:28:54 PST 2019


jhenderson created this revision.
jhenderson added reviewers: dblaikie, MaskRay, ruiu.
Herald added subscribers: rupprecht, eraman.

This is the fourth (and final for now) of a series of patches relating to simplifying llvm-symbolizer tests. See D57441 <https://reviews.llvm.org/D57441>, D57443 <https://reviews.llvm.org/D57443> and D57446 <https://reviews.llvm.org/D57446> for the previous ones. In this one, I have split out several more distinct test cases from the llvm-symbolizer.test test into separate tests, and simplified them in various ways including:

1. Building a test case for spaces in path from source, rather than using a pre-canned binary. This allows deleting of said binary and the source it was built from.
2. Switched to specifying addresses and objects directly on the command-line rather than via stdin.

This also adds an explict test for the ability to specify a file and address as a line in stdin, since the majority of our tests are being migrated away from this approach.


Repository:
  rL LLVM

https://reviews.llvm.org/D57451

Files:
  test/DebugInfo/Inputs/dwarfdump-test3-decl.h
  test/DebugInfo/Inputs/dwarfdump-test3-decl2.h
  test/DebugInfo/Inputs/dwarfdump-test3.cc
  test/DebugInfo/Inputs/dwarfdump-test3.elf-x86-64-space
  test/DebugInfo/llvm-symbolizer.test
  test/DebugInfo/symbolize-gnu-debuglink.test
  test/DebugInfo/symbolize-inlined.test
  test/DebugInfo/symbolize-missing-file.test
  test/tools/llvm-symbolizer/space-in-path.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57451.184297.patch
Type: text/x-patch
Size: 7191 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190130/1c979afd/attachment.bin>


More information about the llvm-commits mailing list