[PATCH] D53765: [RFC prototype] Implementation of asm-goto support in LLVM

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 29 18:10:34 PST 2019


craig.topper marked 3 inline comments as done.
craig.topper added inline comments.


================
Comment at: lib/AsmParser/LLParser.cpp:6250
+    // Pull out the types of all of the arguments...
+    std::vector<Type *> ParamTypes;
+    for (unsigned i = 0, e = ArgList.size(); i != e; ++i)
----------------
chandlerc wrote:
> Not a small vector?
Call and Invoke both use std::vector here...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53765/new/

https://reviews.llvm.org/D53765





More information about the llvm-commits mailing list