[PATCH] D57414: Switch sanitizer-windows bot to annotator scripts

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 29 15:29:25 PST 2019


rnk added inline comments.


================
Comment at: zorg/buildbot/builders/annotated/annotated_builder.py:249
+            for project in projects:
+                path = checkout_locations.get(project, None)
                 if path is None:
----------------
inglorion wrote:
> You could elide the None here; it's the default.
I realized that my "report" call below doesn't actually fail the build. I'm going to just let it throw KeyError, since it indicates a programming error. I wanted to try to make it more usable, but I just don't think this code is going to last very long with the impending monorepo reorg, so let's do the simple thing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57414/new/

https://reviews.llvm.org/D57414





More information about the llvm-commits mailing list