[PATCH] D57414: Switch sanitizer-windows bot to annotator scripts

Bob Haarman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 29 15:23:55 PST 2019


inglorion accepted this revision.
inglorion added a comment.
This revision is now accepted and ready to land.

LGTM, with some suggestions in the comments.



================
Comment at: zorg/buildbot/builders/annotated/annotated_builder.py:249
+            for project in projects:
+                path = checkout_locations.get(project, None)
                 if path is None:
----------------
You could elide the None here; it's the default.


================
Comment at: zorg/buildbot/builders/annotated/sanitizer-windows.py:48
+
+    # Just one stage. This bot is meant to provide quick feedback.
+    check_stages = [True]
----------------
You can omit this; check True for all stages is the default. I don't terribly mind making it explicit, so I'm ok if you prefer to leave it in.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57414/new/

https://reviews.llvm.org/D57414





More information about the llvm-commits mailing list