[PATCH] D56944: [X86] Fix bug in x86_intrcc with arg copy elision

Tue Jan 29 14:13:17 PST 2019

rnk added a comment.

In D56944#1374744 <https://reviews.llvm.org/D56944#1374744>, @craig.topper wrote:

> I think I autogenerated it because I added more run lines and then fixed a bug in the next commit. I'm just in the habit of using the script.

I think auto-generating them is fine, but we should stop checking the instruction encodings since it defeats the wildcarding. If it's valuable to check the encodings, we should have a separate, non-generated test for that.

> So have we been incorrectly positioning the registers in the AVX512 tests?

So, after looking at the offsets, it uncovered a bug. I made a mistake to assume that all fixed stack objects come before the return address. I think I can tweak my X86FrameLowering.cpp change to retain the local area offset adjustment for spilled fixed stack objects (ones that would normally be part of the newly allocated frame, not arguments). I need to look into it more though.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56944/new/

https://reviews.llvm.org/D56944