[PATCH] D57128: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=

Sterling Augustine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 29 08:50:59 PST 2019


saugustine added a comment.

Sorry for the breakage everyone, I'm preparing a rollback now.

I think this shows that everyone using rtlib had their own method of getting the unwind symbols. We ought to figure out a standardized method.

glibc's pthread cancel does assume that the unwind symbols would be available. The --as-needed flags should prevent it from being a hard dependency in plain C, but that doesn't solve the "no file present" problem.

The biggest issue with setting it separately is that would require a second command-line argument every time. Need to think about how to handle that case.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57128/new/

https://reviews.llvm.org/D57128





More information about the llvm-commits mailing list