[lld] r352499 - [ELF] Simplify. NFC

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 29 06:24:36 PST 2019


Author: maskray
Date: Tue Jan 29 06:24:35 2019
New Revision: 352499

URL: http://llvm.org/viewvc/llvm-project?rev=352499&view=rev
Log:
[ELF] Simplify. NFC

Modified:
    lld/trunk/ELF/SymbolTable.cpp

Modified: lld/trunk/ELF/SymbolTable.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SymbolTable.cpp?rev=352499&r1=352498&r2=352499&view=diff
==============================================================================
--- lld/trunk/ELF/SymbolTable.cpp (original)
+++ lld/trunk/ELF/SymbolTable.cpp Tue Jan 29 06:24:35 2019
@@ -326,7 +326,7 @@ Symbol *SymbolTable::addUndefined(String
 
     // We don't report backward references to weak symbols as they can be
     // overridden later.
-    if (Backref && S->Binding != STB_WEAK)
+    if (Backref && !S->isWeak())
       warn("backward reference detected: " + Name + " in " + toString(File) +
            " refers to " + toString(S->File));
   }




More information about the llvm-commits mailing list