[PATCH] D57264: Bump minimum toolchain version

[James Y Knight via Phabricator via llvm-commits]

jyknight added a comment.

In D57264#1374606 <https://reviews.llvm.org/D57264#1374606>, @jfb wrote:

> In D57264#1374596 <https://reviews.llvm.org/D57264#1374596>, @jyknight wrote:
>
> > OK, let's do it.
> >
> > But better watch the buildbots to see if any get broken by the new requirements (hopefully we have at least one that will be?), and add the extra_cmake_args as needed.
>
>
> You mean: pass a cmake argument so the buildbots don't fail? That would seem to defeat the purpose, no?


We need to be aware of which of the llvm project's official buildbots need upgrading. If any are broken, ISTM that the best thing to do is to mark each such individual bot that needs to be upgraded by setting the the LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN cmake argument in the buildbot configuration, to allow them to continue to build. Then, we know where things stand, and over the next month, the owners can upgrade as necessary, without it being an emergency.

Well, really, we should probably have at least one bot using the old version intentionally (assuming there are any now), so we can continue testing it until it's desupported.

The other options -- leaving bots broken (and unable to test any other changes) until someone can get around to upgrading it, or reverting this commit until all bots all been upgraded -- seem strictly worse.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57264/new/

https://reviews.llvm.org/D57264