[PATCH] D57198: [llvm-objcopy] Implement --set-section-flags.

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 28 15:28:02 PST 2019


jakehehrlich accepted this revision.
jakehehrlich added a comment.
This revision is now accepted and ready to land.

Even though this is a large change I think I'm happy with it. Everything was either factoring out common code or handling error messages. I didn't see anything about how error messages were handled that was objectionable.

Please wait on someone else but this LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57198/new/

https://reviews.llvm.org/D57198





More information about the llvm-commits mailing list