[PATCH] D57277: [COFF, ARM64] Don't put jump table into a separate COFF section for EK_LabelDifference32

Mon Jan 28 14:57:09 PST 2019

efriedma added inline comments.

================
Comment at: lib/Target/AArch64/AArch64AsmPrinter.cpp:583
   const TargetLoweringObjectFile &TLOF = getObjFileLowering();
-  MCSection *ReadOnlySec = TLOF.getSectionForJumpTable(MF->getFunction(), TM);
-  OutStreamer->SwitchSection(ReadOnlySec);
+  bool JTInDiffSection = !TLOF.shouldPutJumpTableInFunctionSection(
+      MJTI->getEntryKind() == MachineJumpTableInfo::EK_LabelDifference32,
----------------
I'm a little concerned that this is changing the behavior in more cases than you expect.  Do you have any idea if you're changing the behavior for MachO targets?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57277/new/

https://reviews.llvm.org/D57277