[PATCH] D57256: gn build: Add get.py script to download prebuilt gn, make gn.py run downloaded gn if gn is not on PATH

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 28 11:47:44 PST 2019


thakis added a comment.

Hm, turns out I do need the chmod() after all. Looks like zipfile strips x bits: https://stackoverflow.com/questions/39296101/python-zipfile-removes-execute-permissions-from-binaries

I also added a check that the host system is arm64.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57256/new/

https://reviews.llvm.org/D57256





More information about the llvm-commits mailing list