[PATCH] D57342: gn build: Fix `lld-link: unknown flag: -fuse-ld=lld` warnings on Windows

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

In D57342#1374102 <https://reviews.llvm.org/D57342#1374102>, @thakis wrote:

> In D57342#1374050 <https://reviews.llvm.org/D57342#1374050>, @pcc wrote:
>
> > LGTM
> >
> > (Hmm, where's lld-link coming from? Ah, http://llvm-cs.pcc.me.uk/utils/gn/build/toolchain/BUILD.gn#200 . Maybe that should be using use_lld?)
>
>
> You mean like
>
>   if (clang_base_path != "") {
>     cl = "$clang_base_path/bin/clang-cl"
>     if (use_lld) {
>       link = "$clang_base_path/bin/lld-link"
>     }
>   }
>   
>
> ?


Yes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57342/new/

https://reviews.llvm.org/D57342