[PATCH] D57283: Recognize FreeBSD specific BFD names in OUTPUT_FORMAT

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

I think this part of code needs a little bit of refactoring. I'll submit it so that you can make your change on top of it.



================
Comment at: ELF/ScriptParser.cpp:435
 
-  std::tuple<ELFKind, uint16_t, bool> BfdTuple = readBfdName();
+  std::tuple<ELFKind, uint16_t, uint8_t, bool> BfdTuple = readBfdName();
   if (Config->EKind == ELFNoneKind)
----------------
Instead of recognizing all the combinations of `*-freebsd`, check if `-freebsd` is a suffix of a given string, and set OSABI to FREEBSD and then trim the string.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57283/new/

https://reviews.llvm.org/D57283