[PATCH] D57029: GlobalISel: Fix narrowScalar for load/store with different mem size

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 28 10:19:20 PST 2019


aemerson added a comment.
Herald added a subscriber: Petar.Avramovic.

In what situations can these kinds of loads be generated?

At least for AArch64, the extending loads combiner only runs before legalisation, so it wouldn't have a chance to combine these. In the absence of a G_ANYEXTLOAD opcode, I think having an explicit G_ZEXTLOAD is preferable here even though it's slightly pessimistic.

@dsanders thoughts?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57029/new/

https://reviews.llvm.org/D57029





More information about the llvm-commits mailing list