[PATCH] D57301: [X86] Fix linux32 pic tests to use correct relocation model (PR39684)

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 28 10:04:26 PST 2019


rnk added inline comments.


================
Comment at: test/CodeGen/X86/abi-isel.ll:1
-; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
-
----------------
We have an option, I forget the precise name, -x86_no_scrub_rip, or something like that, that retains address math. I think I used that last time I regenerated this or some other global access .ll test cases. I think it's important to have some instructions for how to update this test case in the future, so can you look into that? If it's only a small change to the scrubber to retain this address arithmetic, that would be worth doing.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57301/new/

https://reviews.llvm.org/D57301





More information about the llvm-commits mailing list