[PATCH] D57190: [MC] Teach the MachO object writer about N_FUNC_COLD

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 28 09:14:54 PST 2019


vsk marked an inline comment as done.
vsk added inline comments.


================
Comment at: llvm/trunk/lib/MC/MCAsmStreamer.cpp:660
+  case MCSA_Cold:
+    // Assemblers currently do not support a .cold directive.
+    return false;
----------------
kledzik wrote:
> Will there be a follow on patch to add a directive to allow cold attribute on symbols?  Otherwise work flows that go through .s files will lose cold information.
Yes, I'm tracking this in rdar://47598547 and rdar://47598666.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57190/new/

https://reviews.llvm.org/D57190





More information about the llvm-commits mailing list