[PATCH] D57224: [CMake] Quick-Fix FileCheck target does not exist when building against LLVM install-tree with COMPILER_RT_INCLUDE_TESTS=ON

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 28 08:48:56 PST 2019


delcypher added inline comments.


================
Comment at: compiler-rt/trunk/test/CMakeLists.txt:17
 
-if(COMPILER_RT_STANDALONE_BUILD)
-  list(APPEND SANITIZER_COMMON_LIT_TEST_DEPS FileCheck)
----------------
Rather than deleting these lines, would this be more sensible?

```
if (NOT COMPILER_RT_STANDALONE_BUILD)
  list(APPEND SANITIZER_COMMON_LIT_TEST_DEPS FileCheck)
endif()
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57224/new/

https://reviews.llvm.org/D57224





More information about the llvm-commits mailing list