[PATCH] D57317: [DAGCombine] Deduplicate addcarry node using commutativity.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 28 04:32:05 PST 2019


RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2527
+  if (CSENode)
+    return SDValue(CSENode, 0);
+
----------------
We already do this in DAGCombiner::combine for plain commutative binops, is it worth generalizing that code?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57317/new/

https://reviews.llvm.org/D57317





More information about the llvm-commits mailing list