[PATCH] D57146: [llvm-objdump] - Print LMAs when dumping section headers.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 28 03:49:11 PST 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:185
+    ShowLMA("show-lma",
+            cl::desc("Display LMA column when dumping ELF section headers"));
+
----------------
grimar wrote:
> jhenderson wrote:
> > This should probably be in the documentation.
> I do not see any documentation files for llvm-objdump around or in the recent commits. Did you have something in mind? Seems we just do not have them =\
Oh well. No, I didn't have anything in mind. I just assumed it would be there alongside e.g. llvm-symbolizer's command guide.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57146/new/

https://reviews.llvm.org/D57146





More information about the llvm-commits mailing list