[PATCH] D33587: [DAGCombine] Do several rounds of combine.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 26 17:50:56 PST 2019


craig.topper added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1437
+      // this won't repeatedly process the same operand.
+      CombinedNodes.insert(N);
+      for (const SDValue &ChildN : N->op_values())
----------------
Don't you need to reset CombineNodes on each iteration?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D33587/new/

https://reviews.llvm.org/D33587





More information about the llvm-commits mailing list