[PATCH] D57063: [CMake] Unify scripts for generating VCS headers

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM with the comment addressed. Like I said, I'd prefer to wait for a few days to give @mgorny another change to take a look, but you're better placed to judge when this should be landed :)



================
Comment at: llvm/cmake/modules/VersionFromVCS.cmake:36
+      string(STRIP "${git_output}" git_output)
+      get_filename_component(git_dir ${git_output} ABSOLUTE)
+      if(EXISTS "${git_dir}/svn/refs")
----------------
This needs `BASE_DIR "${path}"`, right?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57063/new/

https://reviews.llvm.org/D57063