[PATCH] D57128: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=

Sterling Augustine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 25 15:07:22 PST 2019


saugustine added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:2572
+def unwindlib_EQ : Joined<["-", "--"], "unwindlib=">, Flags<[CC1Option]>,
+  HelpText<"Unwind library to use">, Values<"libgcc_eh,compiler-rt-unwind,platform">;
 def sub__library : JoinedOrSeparate<["-"], "sub_library">;
----------------
rsmith wrote:
> I think `libgcc_eh` here should be just `libgcc`, and `compiler-rt-unwind` should be just `compiler-rt`, right?
Good catch. My original design had their own names, but in my own testing I found it awkward so switched out and forgot to update these.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57128/new/

https://reviews.llvm.org/D57128





More information about the llvm-commits mailing list