[PATCH] D57254: [Outliner] Set nounwind for outlined functions

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 25 12:45:01 PST 2019


efriedma added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineOutliner.cpp:1134
+      }))
+    F->addFnAttr(Attribute::NoUnwind);
+
----------------
The outliner will refuse to outline calls that might unwind; you don't need the hasFnAttribute check.  (It might be possible in theory, but it would be complicated to construct the correct unwind info.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57254/new/

https://reviews.llvm.org/D57254





More information about the llvm-commits mailing list