[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

Kar Epker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 25 12:32:25 PST 2019


karepker added a comment.

In D56424#1370908 <https://reviews.llvm.org/D56424#1370908>, @hokein wrote:

> In D56424#1370461 <https://reviews.llvm.org/D56424#1370461>, @karepker wrote:
>
> > Rebasing against master.
> >
> > Not sure if re-arc diffing this is necessary, but I hope it doesn't hurt.
>
>
> Didn't notice that you don't have commit access,  committed in rL352183 <https://reviews.llvm.org/rL352183> (with a small change of the new license).


I just received commit access yesterday but hadn't quite figured out how to use it by the time your modified patch went in. Thanks for taking care of it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56424/new/

https://reviews.llvm.org/D56424





More information about the llvm-commits mailing list